Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide spinner in /cite notify button on logged out #3284

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Hide spinner in /cite notify button on logged out #3284

merged 5 commits into from
Jan 10, 2025

Conversation

lmcnulty
Copy link
Collaborator

Resolves #3283

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (73b7835) to head (8a41143).
Report is 1 commits behind head on staging.

Additional details and impacted files 
@@           Coverage Diff            @@
##           staging    #3284   +/-   ##
========================================
  Coverage    97.17%   97.17%           
========================================
  Files           60       60           
  Lines        12334    12334           
  Branches       306      212   -94     
========================================
  Hits         11986    11986           
- Misses         334      348   +14     
+ Partials        14        0   -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmcnulty lmcnulty marked this pull request as ready for review December 17, 2024 16:02
@lmcnulty lmcnulty requested review from a team and cesarvarela and removed request for a team December 17, 2024 16:03
kepae
kepae approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@kepae kepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge and confirming in staging when ready. :-)

cesarvarela
cesarvarela requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to se a test for this

@kepae kepae requested review from cesarvarela and removed request for cesarvarela January 10, 2025 22:12
@kepae kepae merged commit 4ffbe80 into responsible-ai-collaborative:staging Jan 10, 2025
22 checks passed
@kepae kepae mentioned this pull request Jan 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarvarela cesarvarela cesarvarela requested changes

@kepae kepae kepae approved these changes

Assignees

@lmcnulty lmcnulty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmcnulty @cesarvarela @kepae